audio is prepared, next is MXL part

This commit is contained in:
Dmitry Sergeev
2026-09-16 22:44:27 +03:00
parent ce547451a0
commit 70c966dbad
5 changed files with 333 additions and 5 deletions
+6
View File
@@ -6,8 +6,14 @@ import (
"github.com/qvest-digital/go-mxl/mxl"
)
const (
LevelEBUDBFS = -18.0
LevelSMPTEDBFS = -20.0
)
type Config struct {
Definition flowdef.Audio
LevelDBFS float64
}
func (c Config) ID() string {
+122
View File
@@ -0,0 +1,122 @@
package audio
import (
"encoding/binary"
"fmt"
"math"
)
type Generator interface {
// Generate fills consecutive float32 sample fragments for one channel.
// firstSample is the absolute MXL sample index, so phase does not depend on
// batch or ring-buffer boundaries.
Generate(channel uint, firstSample uint64, fragments ...[]byte) error
}
type SineGenerator struct {
channels uint
sampleRate float64
baseFrequency float64
amplitude float32
}
func NewSineGenerator(
cfg Config,
baseFrequency float64,
) (*SineGenerator, error) {
if cfg.Channels() == 0 {
return nil, fmt.Errorf("channel count must be greater than zero")
}
rate := cfg.Rate()
if rate.Num <= 0 || rate.Den <= 0 {
return nil, fmt.Errorf(
"sample rate numerator and denominator must be greater than zero, got %d/%d",
rate.Num,
rate.Den,
)
}
if math.IsNaN(baseFrequency) || math.IsInf(baseFrequency, 0) || baseFrequency <= 0 {
return nil, fmt.Errorf("base frequency must be finite and greater than zero, got %g", baseFrequency)
}
sampleRate := float64(rate.Num) / float64(rate.Den)
highestFrequency := float64(cfg.Channels()) * baseFrequency
nyquist := sampleRate / 2
if highestFrequency >= nyquist {
return nil, fmt.Errorf(
"highest tone frequency %.0f Hz must be below Nyquist frequency %.0f Hz",
highestFrequency,
nyquist,
)
}
if math.IsNaN(cfg.LevelDBFS) || math.IsInf(cfg.LevelDBFS, 0) {
return nil, fmt.Errorf("audio level must be finite")
}
if cfg.LevelDBFS > 0 {
return nil, fmt.Errorf(
"audio level must not exceed 0 dBFS, got %.2f",
cfg.LevelDBFS,
)
}
if cfg.LevelDBFS < -100 {
return nil, fmt.Errorf(
"audio level must be at least -100 dBFS, got %.2f dBFS",
cfg.LevelDBFS,
)
}
amplitude := math.Pow(10, cfg.LevelDBFS/20)
return &SineGenerator{
channels: cfg.Channels(),
sampleRate: sampleRate,
baseFrequency: baseFrequency,
amplitude: float32(amplitude),
}, nil
}
func (g *SineGenerator) Generate(
channel uint,
firstSample uint64,
fragments ...[]byte,
) error {
if channel >= g.channels {
return fmt.Errorf(
"audio channel %d is out of range [0, %d)",
channel,
g.channels,
)
}
frequency := float64(channel+1) * g.baseFrequency
sampleIndex := firstSample
for fragmentIndex, fragment := range fragments {
if len(fragment)%4 != 0 {
return fmt.Errorf(
"audio fragment %d has %d bytes; float32 data requires a multiple of 4",
fragmentIndex,
len(fragment),
)
}
}
for _, fragment := range fragments {
for offset := 0; offset < len(fragment); offset += 4 {
phase := 2 * math.Pi *
frequency *
float64(sampleIndex) /
g.sampleRate
sample := g.amplitude * float32(math.Sin(phase))
binary.LittleEndian.PutUint32(
fragment[offset:offset+4],
math.Float32bits(sample),
)
sampleIndex++
}
}
return nil
}
+155
View File
@@ -0,0 +1,155 @@
package audio
import (
"bytes"
"encoding/binary"
"math"
"testing"
"mxl-pattern-generator/internal/flowdef"
)
const testAudioID = "b3bb5be7-9fe9-4324-a5bb-4c70e1084449"
func testConfig(t *testing.T, channels uint, rate flowdef.Rational, level float64) Config {
t.Helper()
definition, err := flowdef.NewFloat32Audio(testAudioID, channels, rate)
if err != nil {
t.Fatalf("NewFloat32Audio: %v", err)
}
return Config{Definition: definition, LevelDBFS: level}
}
func decodeSample(data []byte, index int) float32 {
return math.Float32frombits(binary.LittleEndian.Uint32(data[index*4:]))
}
func requireSampleNear(t *testing.T, got, want float32) {
t.Helper()
if math.Abs(float64(got-want)) > 1e-6 {
t.Fatalf("sample = %.8f, want %.8f", got, want)
}
}
func TestNewSineGeneratorValidation(t *testing.T) {
valid := testConfig(t, 2, flowdef.Rational{Numerator: 48000, Denominator: 1}, LevelEBUDBFS)
tests := []struct {
name string
cfg Config
baseHz float64
wantErr bool
}{
{name: "valid", cfg: valid, baseHz: 1000},
{name: "zero channels", cfg: Config{Definition: flowdef.Audio{SampleRate: flowdef.Rational{Numerator: 48000, Denominator: 1}}, LevelDBFS: LevelEBUDBFS}, baseHz: 1000, wantErr: true},
{name: "zero numerator", cfg: Config{Definition: flowdef.Audio{SampleRate: flowdef.Rational{Denominator: 1}, ChannelCount: 1}, LevelDBFS: LevelEBUDBFS}, baseHz: 1000, wantErr: true},
{name: "zero denominator", cfg: Config{Definition: flowdef.Audio{SampleRate: flowdef.Rational{Numerator: 48000}, ChannelCount: 1}, LevelDBFS: LevelEBUDBFS}, baseHz: 1000, wantErr: true},
{name: "zero base", cfg: valid, baseHz: 0, wantErr: true},
{name: "NaN base", cfg: valid, baseHz: math.NaN(), wantErr: true},
{name: "NaN level", cfg: Config{Definition: valid.Definition, LevelDBFS: math.NaN()}, baseHz: 1000, wantErr: true},
{name: "above full scale", cfg: Config{Definition: valid.Definition, LevelDBFS: 1}, baseHz: 1000, wantErr: true},
{name: "too quiet", cfg: Config{Definition: valid.Definition, LevelDBFS: -101}, baseHz: 1000, wantErr: true},
{name: "Nyquist", cfg: testConfig(t, 24, flowdef.Rational{Numerator: 48000, Denominator: 1}, LevelEBUDBFS), baseHz: 1000, wantErr: true},
}
for _, tc := range tests {
t.Run(tc.name, func(t *testing.T) {
_, err := NewSineGenerator(tc.cfg, tc.baseHz)
if (err != nil) != tc.wantErr {
t.Fatalf("error = %v, wantErr %v", err, tc.wantErr)
}
})
}
}
func TestNewSineGeneratorPreservesRationalSampleRate(t *testing.T) {
cfg := testConfig(t, 1, flowdef.Rational{Numerator: 48000, Denominator: 1001}, LevelEBUDBFS)
gen, err := NewSineGenerator(cfg, 1)
if err != nil {
t.Fatalf("NewSineGenerator: %v", err)
}
want := 48000.0 / 1001.0
if math.Abs(gen.sampleRate-want) > 1e-12 {
t.Fatalf("sample rate = %.12f, want %.12f", gen.sampleRate, want)
}
}
func TestSineGeneratorKnownSamplesAndChannels(t *testing.T) {
cfg := testConfig(t, 2, flowdef.Rational{Numerator: 48000, Denominator: 1}, LevelSMPTEDBFS)
gen, err := NewSineGenerator(cfg, 1000)
if err != nil {
t.Fatalf("NewSineGenerator: %v", err)
}
channel0 := make([]byte, 37*4)
if err := gen.Generate(0, 0, channel0); err != nil {
t.Fatalf("Generate channel 0: %v", err)
}
requireSampleNear(t, decodeSample(channel0, 0), 0)
requireSampleNear(t, decodeSample(channel0, 12), 0.1)
requireSampleNear(t, decodeSample(channel0, 24), 0)
requireSampleNear(t, decodeSample(channel0, 36), -0.1)
channel1 := make([]byte, 7*4)
if err := gen.Generate(1, 0, channel1); err != nil {
t.Fatalf("Generate channel 1: %v", err)
}
requireSampleNear(t, decodeSample(channel1, 6), 0.1)
}
func TestSineGeneratorUsesConfiguredBaseFrequency(t *testing.T) {
cfg := testConfig(t, 1, flowdef.Rational{Numerator: 48000, Denominator: 1}, LevelEBUDBFS)
gen, err := NewSineGenerator(cfg, 2000)
if err != nil {
t.Fatalf("NewSineGenerator: %v", err)
}
data := make([]byte, 7*4)
if err := gen.Generate(0, 0, data); err != nil {
t.Fatalf("Generate: %v", err)
}
wantPeak := float32(math.Pow(10, LevelEBUDBFS/20))
requireSampleNear(t, decodeSample(data, 6), wantPeak)
}
func TestSineGeneratorFragmentContinuity(t *testing.T) {
cfg := testConfig(t, 1, flowdef.Rational{Numerator: 48000, Denominator: 1}, LevelEBUDBFS)
gen, err := NewSineGenerator(cfg, 1000)
if err != nil {
t.Fatalf("NewSineGenerator: %v", err)
}
whole := make([]byte, 40*4)
if err := gen.Generate(0, 100, whole); err != nil {
t.Fatalf("Generate whole: %v", err)
}
first := make([]byte, 13*4)
second := make([]byte, 27*4)
if err := gen.Generate(0, 100, first, second); err != nil {
t.Fatalf("Generate fragments: %v", err)
}
joined := append(append([]byte(nil), first...), second...)
if !bytes.Equal(joined, whole) {
t.Fatal("fragmented output differs from contiguous output")
}
}
func TestSineGeneratorRejectsInvalidInputWithoutWriting(t *testing.T) {
cfg := testConfig(t, 1, flowdef.Rational{Numerator: 48000, Denominator: 1}, LevelEBUDBFS)
gen, err := NewSineGenerator(cfg, 1000)
if err != nil {
t.Fatalf("NewSineGenerator: %v", err)
}
first := bytes.Repeat([]byte{0xAA}, 8)
before := append([]byte(nil), first...)
if err := gen.Generate(0, 0, first, make([]byte, 3)); err == nil {
t.Fatal("Generate accepted a misaligned fragment")
}
if !bytes.Equal(first, before) {
t.Fatal("Generate modified data before reporting an invalid fragment")
}
if err := gen.Generate(1, 0, make([]byte, 4)); err == nil {
t.Fatal("Generate accepted an out-of-range channel")
}
}